Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fandom Compatibility + permission overhaul #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

m3w88
Copy link

@m3w88 m3w88 commented Dec 16, 2023

This Pull Request does the following:

  1. changes namespace to match Fandom
  2. new permission of "blogmodedit" is introduced and default granted to sysop usergroup.
  3. added logic to restrict blog editing to author and any user that has blogmodedit permission.
  • This is meant to reduce fights over content viewed as an extension of user space.
  • of course, a formal news team can utilize a collaborative approach for joint editing of blogs

All changes have been tested on MediaWiki 1.39.5 which matches current version of mediawiki that Fandom is running

- removed SP i18n
- created new permission for mods to edit user blogs
- restricted user blog editing to author and mods
- simplified logic for user is blocked
still needs work so that only original blog author and users with permission "blogmodedit" can modify.
@Universal-Omega
Copy link
Owner

This will break backwards compatibility by changing namespace ID, all current on there will disappear, and cannot be accessed. A maintenance script probably needs introduced in order to migrate namespace. Additionally changing the namespace ID conflicts with another extension, I can't remember which, which is why it was changed once before to what it is currently but we can probably change it anyway, thats not a huge problem, both probably shouldn't be used at the same time anyway.

@m3w88
Copy link
Author

m3w88 commented Dec 17, 2023

BlogPages is the extension in question that would conflict and the readme already tells people to not use both. This extension effectively stripping out every dependency + performed code clean up. Since people are advised to not use both extensions, there was no actual namespace id conflict.

if the new permission should be renamed, that is ok with me. Adding this prevents easily avoidable fights by making the determination that blogs are within the userspace.

  • The only reasons for anyone other than author to edit is an admin or an agreed upon collaborative news team. Latter might benefit from a new permission that further restricts who can create a blog or edit a blog.

This pull request was specifically for compatibility with Fandom, if you do not want to merge this then I shall keep this separate.

@m3w88 m3w88 closed this Dec 19, 2023
@Universal-Omega
Copy link
Owner

I will probably merge this eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants