-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fandom Compatibility + permission overhaul #39
base: master
Are you sure you want to change the base?
Conversation
- removed SP i18n - created new permission for mods to edit user blogs - restricted user blog editing to author and mods - simplified logic for user is blocked
still needs work so that only original blog author and users with permission "blogmodedit" can modify.
This will break backwards compatibility by changing namespace ID, all current on there will disappear, and cannot be accessed. A maintenance script probably needs introduced in order to migrate namespace. Additionally changing the namespace ID conflicts with another extension, I can't remember which, which is why it was changed once before to what it is currently but we can probably change it anyway, thats not a huge problem, both probably shouldn't be used at the same time anyway. |
Update extension.json
BlogPages is the extension in question that would conflict and the readme already tells people to not use both. This extension effectively stripping out every dependency + performed code clean up. Since people are advised to not use both extensions, there was no actual namespace id conflict. if the new permission should be renamed, that is ok with me. Adding this prevents easily avoidable fights by making the determination that blogs are within the userspace.
This pull request was specifically for compatibility with Fandom, if you do not want to merge this then I shall keep this separate. |
I will probably merge this eventually. |
This Pull Request does the following:
All changes have been tested on MediaWiki 1.39.5 which matches current version of mediawiki that Fandom is running