Fix issue with priority decrementing too much

UniversityOfHelsinkiCS · Aug 8, 2023 · fd868e7 · fd868e7
1 parent c37df42
commit fd868e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/client/components/Admin/EditSurvey/QuestionItem.tsx b/src/client/components/Admin/EditSurvey/QuestionItem.tsx
@@ -101,7 +101,8 @@ const QuestionItemPositionHandles = ({
     const precedingChilds = questions.filter(
       (q) => q.parentId === precedingQuestion.id
     )
-    const priority = precedingChilds.length ? precedingChilds.length : 0
+
+    const priority = precedingChilds.length >= 1 ? precedingChilds.length : 0
 
     const destination = {
       parentId: precedingQuestion.id,

diff --git a/src/server/routes/question.ts b/src/server/routes/question.ts
@@ -133,7 +133,7 @@ questionRouter.put('/:id/location', async (req: RequestWithUser, res: any) => {
       where: {
         parentId: question.parentId,
         priority: {
-          [Op.gte]: question.priority,
+          [Op.gt]: question.priority,
         },
       },
     })