Skip to content

Commit

Permalink
ID-428 ID7.1 removes W cutout in footer, now applied to <body> elements
Browse files Browse the repository at this point in the history
  • Loading branch information
WarwickGoatee committed Oct 3, 2024
1 parent c6f6364 commit 1148117
Show file tree
Hide file tree
Showing 16 changed files with 35 additions and 24 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ In your application you will need to do the following:

From version 2.9.7 onwards, you can apply the new "ID7.1" styling to the site masthead in your app. To do so:

* Add the `id7-point-1` class to any `id7-utility-masthead` elements in your templates
* Add the `id7-point-1` class to the `<body>` element in your templates
* Replace the logo image `logo.png` with `logo.svg` in your templates
* Update anything app-specific that needs updating - the whole masthead region should have a white background

Expand Down
2 changes: 1 addition & 1 deletion docs/_includes/templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<script src="js/id7-bundle.min.js"></script>
</head>
<body>
<body class="id7-point-1">
<div class="id7-left-border"></div>
<div class="id7-fixed-width-container">
<a class="sr-only sr-only-focusable" href="#main">Skip to main content</a>
Expand Down
4 changes: 2 additions & 2 deletions docs/_includes/utility-masthead.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="id7-utility-masthead id7-point-1">
<div class="id7-utility-masthead">
{% include utility-bar.html %}
{% include masthead.html %}
</div>
</div>
2 changes: 1 addition & 1 deletion docs/_layouts/borderless.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
{% include header-borderless.html %}
</head>
<body>
<body class="id7-point-1">
<div class="id7-left-border"></div>
<div class="id7-fixed-width-container">
<a class="sr-only sr-only-focusable" href="#main">Skip to main content</a>
Expand Down
4 changes: 2 additions & 2 deletions docs/_layouts/default.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
{% include header.html %}
</head>
<body>
<body class="id7-point-1">
<div class="id7-left-border"></div>
<div class="id7-fixed-width-container">
<a class="sr-only sr-only-focusable" href="#main">Skip to main content</a>
Expand Down Expand Up @@ -49,4 +49,4 @@ <h1>{{ page.title }}</h1>
<div class="id7-right-border"></div>

</body>
</html>
</html>
2 changes: 1 addition & 1 deletion docs/_layouts/empty.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
{% include header.html %}
</head>
<body>
<body class="id7-point-1">

{{ content }}

Expand Down
4 changes: 2 additions & 2 deletions docs/_layouts/home.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
{% include header.html %}
</head>
<body>
<body class="id7-point-1">
<div class="id7-left-border"></div>
<div class="id7-fixed-width-container">
<a class="sr-only sr-only-focusable" href="#main">Skip to main content</a>
Expand Down Expand Up @@ -39,4 +39,4 @@ <h1>{{ page.title }}</h1>
<div class="id7-right-border"></div>

</body>
</html>
</html>
2 changes: 1 addition & 1 deletion docs/_layouts/hp-2019.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<link href="/dist/hp-2019/css/hp.css" rel="stylesheet" type="text/css">
<script src="/dist/hp-2019/js/hp.js"></script>
</head>
<body>
<body class="id7-point-1">
<div class="id7-left-border"></div>
<div class="id7-fixed-width-container">
<a class="sr-only sr-only-focusable" href="#main">Skip to main content</a>
Expand Down
2 changes: 1 addition & 1 deletion docs/_layouts/many-menus.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
{% include header.html %}
</head>
<body>
<body class="id7-point-1">
<div class="id7-left-border"></div>
<div class="id7-fixed-width-container">
<a class="sr-only sr-only-focusable" href="#main">Skip to main content</a>
Expand Down
2 changes: 1 addition & 1 deletion docs/_layouts/wide.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
{% include header-wide.html %}
</head>
<body>
<body class="id7-point-1">
<div class="id7-left-border"></div>
<div class="id7-fixed-width-container">
<a class="sr-only sr-only-focusable" href="#main">Skip to main content</a>
Expand Down
11 changes: 11 additions & 0 deletions less/footer.less
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,17 @@ footer {
}
}

// ID-428 Remove W cutout in ID7.1
body.id7-point-1 footer {
.id7-site-footer, .id7-app-footer {
@media screen {
.id7-logo-bleed {
display: none;
}
}
}
}

.id7-non-branded {
.id7-page-footer {
.id7-site-footer, .id7-app-footer {
Expand Down
10 changes: 5 additions & 5 deletions less/header.less
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@
.position-logo-colour-block(@id7-masthead-logo-height-sm, @id7-masthead-logo-width-sm);
}
}
}

&.id7-point-1 {
@media (min-width: @grid-float-breakpoint) {
.id7-masthead .id7-logo a {
height: @id7-point-1-masthead-logo-height-sm;
}
body.id7-point-1 .id7-utility-masthead {
@media (min-width: @grid-float-breakpoint) {
.id7-masthead .id7-logo a {
height: @id7-point-1-masthead-logo-height-sm;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion less/masthead.less
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
}

// Overrides for ID7.1, July 2024, ID-416
.id7-utility-masthead.id7-point-1 .id7-masthead {
body.id7-point-1 .id7-utility-masthead .id7-masthead {
background-image: none;

.id7-logo-column {
Expand Down
4 changes: 2 additions & 2 deletions less/mixins/branding.less
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
background-image: url(@url);
}

.id7-utility-masthead.id7-point-1 {
body.id7-point-1 .id7-utility-masthead {
background-image: none;
background-color: white;
}
Expand Down Expand Up @@ -310,7 +310,7 @@
background-color: @colour;
}

.id7-utility-masthead.id7-point-1::after {
body.id7-point-1 .id7-utility-masthead::after {
background-color: transparent;
}

Expand Down
4 changes: 2 additions & 2 deletions less/utility-bar.less
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@
}

// Overrides for ID7.1, January 2024, ID-416
.id7-utility-masthead.id7-point-1 .id7-utility-bar {
body.id7-point-1 .id7-utility-masthead .id7-utility-bar {
.link-colour(@text-color);

> ul {
Expand All @@ -167,4 +167,4 @@
a > .fa-stack.id7-notifications-badge {
> i { color: #dddddd; }
}
}
}
2 changes: 1 addition & 1 deletion templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

<script src="js/id7-bundle.js"></script>
</head>
<body>
<body class="id7-point-1">
<div class="id7-left-border"></div>
<div class="id7-fixed-width-container">
<a class="sr-only sr-only-focusable" href="#main">Skip to main content</a>
Expand Down

0 comments on commit 1148117

Please sign in to comment.