ID-426 Rework how brand colours are calculated. #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented WCAG functions for contrast. Moved the definitions of key colours up into pairs of colours that are calculated to pass AA contrast, and updated links and headings, both on the page and over the default box styles, use an alternative colour if the brand colour doesn't work. Brand testcard now passes contrast for all the new brand colours. Changed @text-color from #383838 to #202020 for a contrast boost. Added vitest for LESS unit tests.
Secondary nav hover style was set to a darkened version of the secondary colour, but if the text is dark it makes more sense for hover to go lighter. Have implemented this with the contrast function.
|
halfninja
requested review from
a team,
equaliser,
flamingelk,
lk9100,
archanamathur,
pstrapps,
WarwickGoatee and
u2174063
and removed request for
a team
WarwickGoatee
approved these changes
Sep 26, 2024
archanamathur
approved these changes
Sep 26, 2024
flamingelk
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented WCAG functions for contrast. Moved the definitions of key colours up into pairs of colours that are calculated to pass AA contrast, and updated links and headings, both on the page and over the default box styles, use an alternative colour if the brand colour doesn't work.
Brand testcard now passes contrast for all the new brand colours.
Changed @text-color from #383838 to #202020 for a contrast boost.
Added vitest for LESS unit tests.