fix: can overwrite sdk header

Unleash · Feb 6, 2025 · af03c44 · af03c44
1 parent 169221b
commit af03c44
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/unleash/configuration.rb b/lib/unleash/configuration.rb
@@ -55,10 +55,10 @@ def http_headers
         'User-Agent' => "UnleashClientRuby/#{Unleash::VERSION} #{RUBY_ENGINE}/#{RUBY_VERSION} [#{RUBY_PLATFORM}]",
         'UNLEASH-INSTANCEID' => self.instance_id,
         'UNLEASH-APPNAME' => self.app_name,
-        'Unleash-Client-Spec' => CLIENT_SPECIFICATION_VERSION
+        'Unleash-Client-Spec' => CLIENT_SPECIFICATION_VERSION,
+        'UNLEASH-SDK' => "unleash-client-ruby:#{Unleash::VERSION}"
       }.merge!(generate_custom_http_headers)
       headers['UNLEASH-CONNECTION-ID'] = @connection_id
-      headers['UNLEASH-SDK'] = "unleash-client-ruby:#{Unleash::VERSION}"
       headers
     end
 

diff --git a/spec/unleash/configuration_spec.rb b/spec/unleash/configuration_spec.rb
@@ -119,7 +119,7 @@
       config = Unleash::Configuration.new(
         url: 'https://testurl/api',
         app_name: 'test-app',
-        custom_http_headers: { 'X-API-KEY': '123', 'UNLEASH-CONNECTION-ID': 'ignore', 'UNLEASH-SDK': 'ignore' }
+        custom_http_headers: { 'X-API-KEY': '123', 'UNLEASH-CONNECTION-ID': 'ignore' }
       )
 
       expect{ config.validate! }.not_to raise_error