Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gui, tauri): Accept --testnet flag, default to mainnet #106

Merged
merged 10 commits into from
Oct 10, 2024
Merged

feat(gui, tauri): Accept --testnet flag, default to mainnet #106

merged 10 commits into from
Oct 10, 2024

Conversation

binarybaron
Copy link

@binarybaron binarybaron commented Oct 9, 2024 •
edited
Loading

This PR tackles #92

  • Add the tauri-plugin-cli (only on desktop)
  • Check in the frontend if the --testnet flag is set. If it's set we pass testnet=true to the initialize_context command on invokation
  • We add the vite-plugin-top-level-await to allow top level await in all browsers
  • Remove the bitcoin_confirmation_target from settings for simplicity

@binarybaron binarybaron marked this pull request as ready for review October 10, 2024 12:48
@binarybaron binarybaron changed the title feat(gui, tauri): Accept --testnet flag feat(gui, tauri): Accept --testnet flag, default to mainnet Oct 10, 2024
@binarybaron binarybaron merged commit 83f831c into master Oct 10, 2024
29 checks passed
@binarybaron binarybaron mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@binarybaron