Fix COMMAND rules promise handling and update queue status#120
Merged
Conversation
Command rules with FAILED status were re-running on every hook invocation, causing infinite loops when the command always fails (e.g., `false`). Added a check to skip COMMAND rules that are already FAILED, similar to the existing check for PROMPT rules that are already QUEUED. The agent must provide a promise tag to proceed. Also added debugging history documentation and updated AGENTS.md to reference it for future debugging sessions.
Adds changelog entry documenting the bug fix where FAILED command rule queue entries are now properly updated to SKIPPED when agents provide promise tags. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed COMMAND rules promise handling in the hooks system. Previously, when agents provided promise tags for failed command rules, the queue entry remained in FAILED state. Now it's properly updated to SKIPPED, accurately reflecting the rule state.
Changes
Improved promise handling in
rules_check.py:Reorganized debugging documentation:
doc/debugging_history/AGENTS.mdwith template and guidelines for documenting debugging sessionsdoc/debugging_history/hooks.mdto reference AGENTS.md and reflect the improved fixVersion bump: 0.5.1 → 0.5.2 with changelog entry
Implementation Details
The fix has two parts:
This ensures:
Testing
All 4 infinite block tests pass:
🤖 Generated with Claude Code