Skip to content

Use deepwork CLI for hooks instead of python -m #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 5 commits into from
Closed

Use deepwork CLI for hooks instead of python -m #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d31b43a
Initial plan
Copilot Jan 23, 2026
47a1faf
Fix hooks to use deepwork CLI instead of python directly for Homebrew…
Copilot Jan 23, 2026
4153ec9
Update .claude/settings.json to use deepwork hook command
Copilot Jan 23, 2026
ea4f90d
Update documentation and manual tests to use deepwork hook command
Copilot Jan 23, 2026
75d217e
Merge branch 'main' into copilot/fix-python-availability-homebrew
ncrmro Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,4 @@
}
]
}
}
}
2 changes: 1 addition & 1 deletion manual_tests/test_infinite_block_command/test_infinite_block_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

=== TEST CASE 1: Rule SHOULD fire (command fails, infinite block) ===
1. Edit this file (add a comment below the marker)
2. Run: echo '{}' | python -m deepwork.hooks.rules_check
2. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
3. Expected: Block with command error AND promise skip instructions

=== TEST CASE 2: Rule should NOT fire (promise provided) ===
Expand Down
4 changes: 2 additions & 2 deletions manual_tests/test_infinite_block_prompt/test_infinite_block_prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

=== TEST CASE 1: Rule SHOULD fire (infinite block) ===
1. Edit this file (add a comment below the marker)
2. Run: echo '{}' | python -m deepwork.hooks.rules_check
2. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
3. Expected: "Manual Test: Infinite Block Prompt" appears in output with decision="block"
4. The block message should explain that a promise is required

Expand All @@ -30,7 +30,7 @@
echo '{"role":"assistant","message":{"content":[{"type":"text","text":"<promise>Manual Test: Infinite Block Prompt</promise>"}]}}' > /tmp/transcript.jsonl

2. Run with transcript:
echo '{"transcript_path":"/tmp/transcript.jsonl"}' | python -m deepwork.hooks.rules_check
echo '{"transcript_path":"/tmp/transcript.jsonl"}' | deepwork hook deepwork.hooks.rules_check

3. Expected: {} (empty JSON = allow)

Expand Down
6 changes: 3 additions & 3 deletions manual_tests/test_multi_safety/test_multi_safety.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@
=== TEST CASE 1: Rule SHOULD fire ===
1. Edit this file (add a comment below the marker)
2. Do NOT edit any safety files
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Multi Safety" appears in output

=== TEST CASE 2: Rule should NOT fire (changelog edited) ===
1. Edit this file (add a comment below the marker)
2. ALSO edit test_multi_safety_changelog.md
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Multi Safety" does NOT appear

=== TEST CASE 3: Rule should NOT fire (version edited) ===
1. Edit this file (add a comment below the marker)
2. ALSO edit test_multi_safety_version.txt
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Multi Safety" does NOT appear

=== RULE LOCATION ===
Expand Down
6 changes: 3 additions & 3 deletions manual_tests/test_pair_mode/test_pair_mode_trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@
=== TEST CASE 1: Rule SHOULD fire ===
1. Edit this file (add a comment below the marker)
2. Do NOT edit test_pair_mode_expected.md
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Pair Mode" appears in output

=== TEST CASE 2: Rule should NOT fire (both edited) ===
1. Edit this file (add a comment below the marker)
2. ALSO edit test_pair_mode_expected.md
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Pair Mode" does NOT appear

=== TEST CASE 3: Rule should NOT fire (expected only) ===
1. Do NOT edit this file
2. Edit ONLY test_pair_mode_expected.md
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Pair Mode" does NOT appear
(This verifies the ONE-WAY nature of pair mode)

Expand Down
4 changes: 2 additions & 2 deletions manual_tests/test_set_mode/test_set_mode_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
=== TEST CASE 1: Rule SHOULD fire ===
1. Edit this file (add a comment below the marker)
2. Do NOT edit test_set_mode_test.py
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Set Mode" appears in output

=== TEST CASE 2: Rule should NOT fire ===
1. Edit this file (add a comment below the marker)
2. ALSO edit test_set_mode_test.py
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Set Mode" does NOT appear

=== RULE LOCATION ===
Expand Down
4 changes: 2 additions & 2 deletions manual_tests/test_trigger_safety_mode/test_trigger_safety_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
=== TEST CASE 1: Rule SHOULD fire ===
1. Edit this file (add a comment below the marker)
2. Do NOT edit test_trigger_safety_mode_doc.md
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Trigger Safety" appears in output

=== TEST CASE 2: Rule should NOT fire ===
1. Edit this file (add a comment below the marker)
2. ALSO edit test_trigger_safety_mode_doc.md
3. Run: echo '{}' | python -m deepwork.hooks.rules_check
3. Run: echo '{}' | deepwork hook deepwork.hooks.rules_check
4. Expected: "Manual Test: Trigger Safety" does NOT appear

=== RULE LOCATION ===
Expand Down
Loading