Skip to content

Comments

Fix test-homebrew.sh: uninstall before tap recreation#203

Merged
ncrmro merged 2 commits intomainfrom
copilot/fix-test-hombrew-setup
Feb 9, 2026
Merged

Fix test-homebrew.sh: uninstall before tap recreation#203
ncrmro merged 2 commits intomainfrom
copilot/fix-test-hombrew-setup

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

The script fails when deepwork is already installed from local/deepwork-test tap because brew tap-new conflicts with existing installations from that tap.

Changes

  • Move brew uninstall deepwork before tap operations (line 46, previously line 54)

Before:

brew untap "$TAP_NAME" 2>/dev/null || true
brew tap-new --no-git "$TAP_NAME"
# ... modify formula ...
brew uninstall deepwork 2>/dev/null || true  # Too late
brew install --verbose "$TAP_NAME/deepwork"

After:

brew uninstall deepwork 2>/dev/null || true  # Clean state first
brew untap "$TAP_NAME" 2>/dev/null || true
brew tap-new --no-git "$TAP_NAME"
# ... modify formula ...
brew install --verbose "$TAP_NAME/deepwork"

Ensures idempotent execution when run multiple times.

Original prompt

test-hombrew.sh should uninstall and untap before trying to tap and install . Currently this fails


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: ncrmro <8276365+ncrmro@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix hombrew script to uninstall and untap before installing Fix test-homebrew.sh: uninstall before tap recreation Feb 6, 2026
Copilot AI requested a review from ncrmro February 6, 2026 15:07
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

@ncrmro ncrmro marked this pull request as ready for review February 9, 2026 17:02
@ncrmro ncrmro merged commit c6bed52 into main Feb 9, 2026
3 of 4 checks passed
@ncrmro ncrmro deleted the copilot/fix-test-hombrew-setup branch February 9, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants