Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,14 @@ We use a skip pattern so the same required checks pass in both PR and merge queu

### How It Works

All workflows specify explicit branch targeting:
All workflows specify explicit branch targeting and the `checks_requested` type:

```yaml
on:
pull_request:
branches: [main]
merge_group:
types: [checks_requested]
branches: [main]
workflow_dispatch: # Enables manual triggering for testing
```
Expand Down Expand Up @@ -71,7 +72,7 @@ In GitHub branch protection rules, require these checks:

All checks will pass in both PR and merge queue contexts (either by running or by being skipped).

**Note**: The explicit branch targeting in `merge_group` triggers is critical for workflows to run properly in the merge queue. Without this, GitHub may not trigger the workflows and they will remain in "expected" state.
**Note**: The explicit `types: [checks_requested]` and branch targeting in `merge_group` triggers is critical for workflows to run properly in the merge queue. The `types` parameter is recommended by GitHub to future-proof against new activity types. Without proper configuration, GitHub may not trigger the workflows and they will remain in "expected" state.

## Workflow Details

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/cla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
branches: [main]
# Run in merge queue but skip the step (shows as passing check)
merge_group:
types: [checks_requested]
branches: [main]
workflow_dispatch:

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/claude-code-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
branches: [main]
# Run in the merge queue to validate before merging
merge_group:
types: [checks_requested]
branches: [main]

# Ensure only one instance runs at a time per PR/branch
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
pull_request:
branches: [main]
merge_group:
types: [checks_requested]
branches: [main]
workflow_dispatch:

Expand Down