Merged
Conversation
The cla.yml workflow had two separate jobs with different names: - merge-queue-pass: ran in merge queue - cla-check: ran for PRs only When branch protection requires 'cla-check' to pass, the merge queue would wait indefinitely because only 'merge-queue-pass' was being reported as a status, not 'cla-check'. Consolidate into a single 'cla-check' job that runs for all event types, using step-level conditions to skip the actual CLA work in merge queue context (since CLA is already verified at PR time).
The merge queue creates temporary refs like gh-readonly-queue/main/pr-N-xxx. The branches: [main] filter was preventing workflows from triggering because the ref name doesn't match the simple "main" glob pattern. Since merge queue is only enabled for specific branches via branch protection rules anyway, the branches filter on merge_group events is redundant and causes the workflows to never run. This fixes all 4 required checks (tests, claude-code-e2e, cla-check, validate-generation) not running in merge queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.