Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vps 49/fix zooming issue #244

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Vps 49/fix zooming issue #244

wants to merge 6 commits into from

Conversation

xche529
Copy link
Contributor

@xche529 xche529 commented Sep 30, 2024

Describe the issue

image and buttons not changing size in play canvas when zooming

Describe the solution

change the component size with a zooming factor

Risk

Potential zooming factor issue with different browser

Definition of Done

  • Code peer-reviewed
  • Wiki Documentation is written and up to date
  • Unit tests written and passing
  • Integration tests written and passing
  • Continuous Integration build passing
  • Acceptance criteria met
  • Deployed to production environment

Reviewed By

Who reviewed your PR - for commit history once merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsatulbox itsatulbox Awaiting requested review from itsatulbox

@laibatool792 laibatool792 Awaiting requested review from laibatool792

@sbeen56 sbeen56 Awaiting requested review from sbeen56

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xche529