Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOL-248/match the bg colour of the dashbaoard to the side nav bar #261

Merged
merged 1 commit into from
Sep 17, 2024
Merged

VOL-248/match the bg colour of the dashbaoard to the side nav bar #261

merged 1 commit into from
Sep 17, 2024

Conversation

hgao080
Copy link
Contributor

@hgao080 hgao080 commented Sep 16, 2024 •
edited
Loading

  • Updated colour of selected tab to match the bg colour of the dashboard
  • Tabs now don't have a sight pixel overlap
  • If zoomed in a lot will see that the edges don't perfectly align with the side due to the SVG mask but unnoticeable at normal screen size

image

@hgao080 hgao080 linked an issue Sep 16, 2024 that may be closed by this pull request
match the bg colour of the dashbaoard to the side nav bar #248
Closed
John-Moore-UOA
John-Moore-UOA approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@John-Moore-UOA John-Moore-UOA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@John-Moore-UOA John-Moore-UOA merged commit ed2320b into main Sep 17, 2024
2 checks passed
@John-Moore-UOA John-Moore-UOA deleted the VOL-248/match-the-bg-colour-of-the-dashbaoard-to-the-side-nav-bar branch September 17, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Moore-UOA John-Moore-UOA John-Moore-UOA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

match the bg colour of the dashbaoard to the side nav bar
2 participants
@hgao080 @John-Moore-UOA