-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export LFMCMC #27
Export LFMCMC #27
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 19.14% 19.07% -0.07%
==========================================
Files 34 36 +2
Lines 1776 1782 +6
==========================================
Hits 340 340
- Misses 1436 1442 +6 ☔ View full report in Codecov by Sentry. |
@gvegayon I implemented |
I haven't executed the C++ version in a while, so maybe it is not so different now! Anyhow, I think that, for the moment, the only relevant issue is the following warning reported by R CMD check: Found the following significant warnings:
../inst/include/epiworld/math/lfmcmc/lfmcmc-meat-print.hpp:55:36: warning: format '%ld' expects argument of type 'long int', but argument 2 has type 'size_t' {aka 'long long unsigned int'} [-Wformat=] That is on the C++ side, so it would need to be addressed directly on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments before merging. The main one is to ensure the version in DESCRIPTION
matches the version of epiworld.hpp
. Once that's addressed, you can merge!
@gvegayon Does everything look okay now? |
Please squash and merge :) |
This pull request introduces several significant updates, including the addition of a new Likelihood-Free Markov Chain Monte Carlo (LFMCMC) functionality, various improvements to the codebase, and updates to documentation and configuration files.
New Features:
LFMCMC
class and associated methods for performing LFMCMC simulations (R/LFMCMC.R
).R/cpp11.R
).NAMESPACE
to export new LFMCMC-related functions (NAMESPACE
). [1] [2] [3] [4]Codebase Improvements:
.devcontainer/Dockerfile
).cinttypes
to VSCode settings (.vscode/settings.json
).docs
target and added a newdev
target for building without vignettes (Makefile
).Documentation and Configuration:
roxygenize
function call in the Makefile (Makefile
).epiworldR.Rproj
).Minor Enhancements:
DataBase
class for transition matrices and recording transmissions (inst/include/epiworld/database-bones.hpp
,inst/include/epiworld/database-meat.hpp
). [1] [2] [3] [4] [5]LFMCMC
class to usestd::shared_ptr
for the random number engine (inst/include/epiworld/math/lfmcmc/lfmcmc-bones.hpp
).distributions.hpp
file for mathematical distributions (inst/include/epiworld/math/distributions.hpp
).Version Update:
inst/include/epiworld/epiworld.hpp
).These changes collectively enhance the functionality, maintainability, and usability of the codebase.