Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed patch - patch #30

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Seed patch - patch #30

merged 4 commits into from
Nov 4, 2024

Conversation

gvegayon
Copy link
Member

@gvegayon gvegayon commented Nov 4, 2024

@apulsipher, since I changed how seeds are handled, a test was failing (expectedly). I just updated the values of the test. It should pass now.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.18%. Comparing base (971d4f3) to head (c4878da).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   19.14%   19.18%   +0.04%     
==========================================
  Files          34       34              
  Lines        1776     1777       +1     
==========================================
+ Hits          340      341       +1     
  Misses       1436     1436              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@apulsipher apulsipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apulsipher apulsipher merged commit e2797fa into main Nov 4, 2024
15 checks passed
@apulsipher apulsipher deleted the seed-patch branch November 4, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants