Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Test Cases #84

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

More Test Cases #84

wants to merge 7 commits into from

Conversation

IsaccBarker
Copy link
Collaborator

Fix #79.

@IsaccBarker IsaccBarker self-assigned this Jan 15, 2025
@IsaccBarker IsaccBarker added awaiting review Awaiting review blocked Blocked by another issue labels Jan 15, 2025
@apulsipher apulsipher self-assigned this Jan 15, 2025
@IsaccBarker
Copy link
Collaborator Author

Blocked by #89.

apulsipher
apulsipher requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@apulsipher apulsipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always happy to see more tests! Just a few changes to make then it'll be good to go

tests/test_saver.py Outdated Show resolved Hide resolved
tests/test_basic.py Outdated Show resolved Hide resolved
@apulsipher apulsipher added changes requested Changes were requested before merging. and removed blocked Blocked by another issue awaiting review Awaiting review labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apulsipher apulsipher apulsipher requested changes

Assignees

@apulsipher apulsipher

@IsaccBarker IsaccBarker

Labels
changes requested Changes were requested before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More Test Cases
2 participants
@IsaccBarker @apulsipher