Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes): node_group re-creation waits for deletion first #428

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix(kubernetes): node_group re-creation waits for deletion first #428

merged 2 commits into from
Oct 31, 2023

Conversation

villevsv-upcloud
Copy link
Contributor

@villevsv-upcloud villevsv-upcloud commented Oct 25, 2023 •
edited by peknur
Loading

TODO:

@villevsv-upcloud villevsv-upcloud requested a review from a team as a code owner October 25, 2023 12:58
peknur
peknur approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@peknur peknur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Tested it locally and everything seems to works as expected.
I have a bit mixed feelings on should we wait node group(s) state when creating the service, but I guess it's always better to have service fully running at the end and this will also remove node group state update after creation.

@villevsv-upcloud villevsv-upcloud merged commit 78f1941 into main Oct 31, 2023
2 checks passed
@villevsv-upcloud villevsv-upcloud deleted the fix/kubernetes-node-group-wait branch October 31, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peknur peknur peknur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@villevsv-upcloud @peknur