Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbaas): add termination_protection field #690

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

kangasta
Copy link
Contributor

@kangasta kangasta commented Nov 27, 2024

Also replaces SDKv2 testing helper with github.com/hashicorp/terraform-plugin-testing to be able to use ConfigVariables in test steps and skips EOL object storage tests unless TF_ACC_OBJSTO_EOL environment variable is set to non-empty value.

@kangasta kangasta requested a review from a team as a code owner November 27, 2024 13:57
@kangasta kangasta force-pushed the feat/dbaas-termination_protection branch 2 times, most recently from 93a5e63 to cbb0ca2 Compare December 2, 2024 14:24
@kangasta kangasta force-pushed the feat/dbaas-termination_protection branch from cbb0ca2 to 3fa983d Compare December 2, 2024 16:20
Copy link
Contributor

@peknur peknur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kangasta kangasta merged commit 3c548b4 into main Dec 3, 2024
4 of 5 checks passed
@kangasta kangasta deleted the feat/dbaas-termination_protection branch December 3, 2024 11:32
github-actions bot pushed a commit that referenced this pull request Dec 3, 2024
kangasta added a commit that referenced this pull request Dec 3, 2024
Co-authored-by: kangasta <kangasta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants