Add multiplayer #15
Open
Add multiplayer #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zotho
suggested changes
Apr 14, 2022
Comment on lines
+33
to
+36
| """ | ||
| Only available in multiplayer. | ||
| :return: | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """ | |
| Only available in multiplayer. | |
| :return: | |
| """ | |
| """Draw score table. | |
| Only available in multiplayer. | |
| """ |
| daemon=True | ||
| ).start() | ||
| while not self.client_running: | ||
| ... |
Comment on lines
+36
to
+39
| if event["event_type"] == Events.update_score.value: | ||
| self.score_table = event["value"] | ||
|
|
||
| elif event["event_type"] == Events.id_message.value: |
There was a problem hiding this comment.
Enums can be checked for equality by is:
Suggested change
| if event["event_type"] == Events.update_score.value: | |
| self.score_table = event["value"] | |
| elif event["event_type"] == Events.id_message.value: | |
| event_variant = Events(event["event_type"]) | |
| if event_variant is Events.update_score: | |
| self.score_table = event["value"] | |
| elif event_variant is Events.id_message: |
| self.id = event["value"] | ||
|
|
||
| def on_open(self, ws: WebSocketApp): | ||
| self.logger.info("open connection with host: {}".format(ws.url)) |
There was a problem hiding this comment.
logging library does formatting for us:
See: https://docs.python.org/3/howto/logging.html#logging-variable-data
Suggested change
| self.logger.info("open connection with host: {}".format(ws.url)) | |
| self.logger.info("open connection with host: %s", ws.url) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.