-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add England and Wales census tables #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgreenbury
reviewed
Jul 8, 2024
`with TemporaryDirectory(delete=del_temp_dir):` is Py3.12 only. We need to be able to support Py 3.11
sgreenbury
reviewed
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP PR seeks to incorporate census attributes for England and Wales.
This supersedes #40
Current Status:
Todo
def _derived_metrics()
- This will need a very different implementation from the equivalent NI method. NI's source data is row-based, whereas EW is already column-based.Problems to solve(d)
Decide whether or not to include the extra geometries in thev0.2
release..
in the filename, e.g.census2021-ts002-lsoa..csv
. We need to be able to gracefully handle this situation._derived_metrics()
method.We need to find way to map the source metric names and HXL tags (possibly this should be in a separate PR)For future issues/PRs (eg after v0.2)