Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise metadata filepaths and module names #122

Merged
merged 10 commits into from
Jul 1, 2024
Merged

Revise metadata filepaths and module names #122

merged 10 commits into from
Jul 1, 2024

Conversation

sgreenbury
Copy link
Collaborator

@sgreenbury sgreenbury commented Jun 26, 2024 •
edited by penelopeysm
Loading

Closes #120, closes #104

This PR:

  • Ensures the relative filepath from the basepath is included in metric and geometry metadata assets
  • Constructs the key_prefix from the country ID and includes the CountryMetadata as a non-serialized field in the GeometryMetadata

@sgreenbury sgreenbury marked this pull request as ready for review June 26, 2024 20:38
@sgreenbury sgreenbury requested a review from penelopeysm June 27, 2024 10:26
penelopeysm
penelopeysm approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Otherwise, looks great!!)

python/popgetter/io_managers/__init__.py Outdated Show resolved Hide resolved
python/popgetter/assets/gb_nir/__init__.py Outdated Show resolved Hide resolved
@sgreenbury
Copy link
Collaborator Author

Thanks @penelopeysm! I'll go ahead and merge this now.

@sgreenbury sgreenbury merged commit 86ab0ed into main Jul 1, 2024
8 checks passed
@sgreenbury sgreenbury deleted the 120-filepaths branch July 1, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penelopeysm penelopeysm penelopeysm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Popgetter
Status: Done:
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update metadata filepaths to include prefixes Update key prefix to be country ID
2 participants
@sgreenbury @penelopeysm