Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out England and Wales census from UK wide assets #143

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

andrewphilipsmith
Copy link
Collaborator

The PR (rightly) separates out the England and Wales census from the UK-wide data.

  • A new asset group (gb_eaw) and job (job_gb_eaw) handles the England and Wales census.
  • The UK asset group and job, now only includes the Ordnance Survey OpenData.

Separate out England and Wales from the rest of the UK
@@ -47,7 +48,7 @@
# - The catalog must to parsed into an Dagster Partition, so that
# - individual tables can be uploaded to the cloud table sensor
# - the metadata object can be created for each table/metric
from .united_kingdom import country
# from .united_kingdom import country
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# from .united_kingdom import country

Copy link
Collaborator

@sgreenbury sgreenbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@andrewphilipsmith andrewphilipsmith merged commit 8683f79 into main Jul 10, 2024
8 checks passed
@andrewphilipsmith andrewphilipsmith deleted the seperate-EAW-and-UK branch July 10, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done:
Development

Successfully merging this pull request may close these issues.

2 participants