Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev setup instructions in readme.md #60

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

andrewphilipsmith
Copy link
Collaborator

Adds advice to create a virtualenv before installing popgetter in the setup instructions.

@andrewphilipsmith andrewphilipsmith merged commit b8be743 into main Mar 15, 2024
4 checks passed
@andrewphilipsmith andrewphilipsmith deleted the fix-docs branch March 15, 2024 10:12
Copy link
Collaborator

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running through now. Two observations:

  1. I needed to sudo apt-get install libxml2-dev libxslt1-dev on Ubuntu 22; there was a system dependency on these two dev libraries. I'll add a suggestion

  2. Not sure why, but many versions of packages like fsspec are being installed. I guess transitive dependencies pin to many different versions of this

@dabreegster
Copy link
Collaborator

Ah, INFO: pip is looking at multiple versions of dagster to determine which version is compatible with other requirements. This could take a while.. Do we have a lockfile with precise versions that we should check in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done:
Development

Successfully merging this pull request may close these issues.

2 participants