Encoder using interrupts; faceplate for bigger screen; hat for smaller encoder#5
Open
grzesiek2201 wants to merge 2 commits intoUrbanCircles:mainfrom
Open
Encoder using interrupts; faceplate for bigger screen; hat for smaller encoder#5grzesiek2201 wants to merge 2 commits intoUrbanCircles:mainfrom
grzesiek2201 wants to merge 2 commits intoUrbanCircles:mainfrom
Conversation
…en; add hat for smaller encoder
|
Nice code, but could you link the library please? There's none available in Arduino IDE, and there are different versions online. Thx! |
Author
|
Of course, my bad! Here's the used library: https://github.com/codingABI/KY040 |
Owner
|
this looks great - would the source of the library be an issue for some? not familiar with this, and I can see this guy asking for it. should we include the link into the sketch itself, if the library is not easily discovered? |
Author
|
How about we include the library .h file itself? Let me modify this pull request to reflect that. |
Author
|
Hey @UrbanCircles, the pull request has been modified already. |
SillyHats
reviewed
Mar 18, 2025
| /** Library version */ | ||
| #define KY040_VERSION "1.0.1" | ||
|
|
||
| #include <arduino.h> |
There was a problem hiding this comment.
This caused an error for me in Arduino IDE until I changed arduino.h to Arduino.h
hackervole
added a commit
to hackervole/igor
that referenced
this pull request
Jun 27, 2025
This is based on an upstream PR (UrbanCircles#5), but I took a slightly different approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributions
sketch_sep25a.inosketch3D Parts / Bigger screen faceplate / Faceplate-bigger-screen.stl3D Parts / Smaller encoder hat / hat-smaller-encoder.stlChanges in wiring
None