Adds support for nested function arguments. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the logic executed when arguments are not explicitly passed to `getopts_long` and instead they are determined from the call stack (using `BASH_ARGV`), which attempts to match the default argument behavior of the builtin `getopts` command. Based on my tests, the updated logic fixes all the bugs I found, e.g. when calling `getopts_long` within nested functions, etc. Also, while testing, I noticed the use of `BASH_ARGV` requires `shopt -s extdebug` to be enabled. Also, the logic may not work in all scenarios, e.g. when the arguments have been shifted, etc. However, this was always the case, and is not new to the changes in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the default argument logic allowing it to collect arguments just for the current function, using BASH_ARGC as a boundary. It’s designed to make things more reliable in nested contexts, allowing the user to work only with the arguments relevant to the current function call.