Support Batch Document Get #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/firestore/repo.ex
Outdated
| Firestore.Decoder.decode(response) | ||
| end | ||
| end | ||
|
|
||
| def batch_get_documents(document_paths, params \\ []) do |
There was a problem hiding this comment.
document_ids or document_tokens
mujahed-odeh
approved these changes
Jul 24, 2024
…g it inside the repo method. - Include the path for each document since the order of the response isn't guaranteed to match the input. - Since we include each path for each requested document, it's better not to filter out missing documents. Include them with value `nil` for document. - Fix the capability of passing body params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this requires the project's URL in the config to be changed from
projects/xxx/databases/(default)/documentstoprojects/xxx/databases/(default)