fix: remove hardcoded default server URL from mobile app#136
Open
skywinder wants to merge 2 commits intoUshadow-io:devfrom
Open
fix: remove hardcoded default server URL from mobile app#136skywinder wants to merge 2 commits intoUshadow-io:devfrom
skywinder wants to merge 2 commits intoUshadow-io:devfrom
Conversation
Users now set the server URL during first login instead of having a hardcoded default. Also fixed missing import for authStorage functions.
- Add EXPO_PUBLIC_DEFAULT_SERVER_URL env var support - Create .env.example for documentation - Update README with build configuration instructions
Contributor
Author
|
this is quick update for https://github.com/Ushadow-io/Ushadow/pull/96/files#r2725618390 |
Member
|
we don't need this, that's whatthe QR code is for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDefaultServerUrlandsetDefaultServerUrlin LoginScreenChanges
config.ts: ChangedDEFAULT_SERVER_URLfrom hardcoded URL to empty stringauthStorage.ts: Updated to return empty string when no user default is setLoginScreen.tsx: Added missing imports for auth storage functionsTest plan