YDA-5059: add hierarchical keyword selector #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravox
commented
Dec 11, 2024
| @@ -0,0 +1,237 @@ | |||
| import React from 'react' | |||
| import axios from 'axios' | |||
| import { TreeSelect, ConfigProvider, theme } from 'antd' | |||
There was a problem hiding this comment.
I find TreeSelect from antd is really nice for the keyword selector, but I am a little bit concerned about how much bigger it makes the final js file (goes from about 800kb to 1.2 mb). This also makes the metadata form load a little slower. Not sure if there is some tree shaking I can do.
claravox
commented
Dec 11, 2024
claravox
commented
Dec 11, 2024
claravox
changed the title
This was referenced Dec 11, 2024
claravox
commented
Dec 13, 2024
|
In the end I kept the dark theme on the TreeKeywordSelector the same dark and white theme across all themes (uu, vu, wur) to keep it consistent with the theming we already have on react-select fields in dark mode. |
Co-authored-by: Lazlo Westerhof <l.r.westerhof@uu.nl>
lwesterhof
force-pushed
the
development-keyword-selector
branch
from
e533449 to
47dc493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Of the UI tests, I have run this against the ui_meta tests (including the new one I added) and it passes those.
Main changes:
This was tested on a Yoda before the update to irods 4.3.3 etc.