-
-
Notifications
You must be signed in to change notification settings - Fork 132
fix: update pr-contributors.html path in index.html and files + images paths, syntax bugs & rendering logic in pr-contributors.html (fixes #391), #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Saminakalwar is attempting to deploy a commit to the vaibhavbabele's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Hi @Saminakalwar, thank you for opening this Pull Request!
Happy Contributing! 🚀 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Mistake in fetching data, wrong points and selecting all contributor including me. |
can u give me intended results if u have at one place plz? |
|
|
Fixes #391
📌 Summary
Corrected multiple issues in pr-contributors.html so contributors’ data and certificate links render correctly.
Also corrected the pr-contributors.html path in index.html.
🔧 Changes Made
✅ Checklist
Before: page with broken link to pr-contributors.html in index.html
https://www.loom.com/share/717998d5e711451496fbe9d7dcc87ea9?sid=3121815e-f4b8-4e44-b135-350aae879c53
After: Page after updating link to pr-contributors.html
Here is the video link for it:
https://www.loom.com/share/2cd05199d8b84157803db78aefe68def?sid=8764d542-9daa-4422-9736-e0cd8dc82228
After huge Loading of contributors data we found this error:
After: Page after updating incorrect links to side bar, icon, certificate.html, broken tags and rendering logic etc
Here is the recording link after All changes :