Skip to content

Conversation

@Saminakalwar
Copy link

@Saminakalwar Saminakalwar commented Sep 5, 2025

Fixes #391

📌 Summary

Corrected multiple issues in pr-contributors.html so contributors’ data and certificate links render correctly.
Also corrected the pr-contributors.html path in index.html.

🔧 Changes Made

  • Fixed favicon path → ../../favicon/favicon.ico
  • Fixed dark/light mode icon path → ../../images/moon.png
  • Corrected sidebar.js path → ../../js/sidebar.js
  • Fixed certificate.html paths → ../../pages/certificate/certificate.html?...
  • Fixed br tag bug inside loading message
  • Removed extra closing tags in
  • Corrected podium logic → explicitly used topThree[0], topThree[1], topThree[2]

✅ Checklist

  • Bug fixes applied
  • Verified page loads correctly
  • Certificates download with correct params
  • PRs render with labels, levels, and merged date
  • Screenshots attached (add before/after screenshots)

Before: page with broken link to pr-contributors.html in index.html

https://www.loom.com/share/717998d5e711451496fbe9d7dcc87ea9?sid=3121815e-f4b8-4e44-b135-350aae879c53

After: Page after updating link to pr-contributors.html

  • no side bar
  • no favicon icon
  • no certificate download
  • no contributors data rendering

Here is the video link for it:

https://www.loom.com/share/2cd05199d8b84157803db78aefe68def?sid=8764d542-9daa-4422-9736-e0cd8dc82228

After huge Loading of contributors data we found this error:

Screenshot 2025-09-06 001324

After: Page after updating incorrect links to side bar, icon, certificate.html, broken tags and rendering logic etc

Screenshot 2025-09-06 001436 Screenshot 2025-09-06 001505 Screenshot 2025-09-06 001556

Here is the recording link after All changes :

@vercel
Copy link

vercel bot commented Sep 5, 2025

@Saminakalwar is attempting to deploy a commit to the vaibhavbabele's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Sep 5, 2025

👋 Hi @Saminakalwar, thank you for opening this Pull Request!
🔧 Please ensure the following:

  • ✅ Resolve any merge conflicts, if they exist.make sure you have updated your local repo to avoid conflicts. and solve in your local repo. do not solve in github editor.try to solve in your local repo in vs code or any other editor.
  • 🧾 Clearly mention the issue number you are solving (e.g., Fixes #issue_number).
  • 📎 Please update your PR description if anything is unclear or incorrect.
  • 📷 Attach a screenshot or screen recording of your fix.
  • 💬 Kindly share the PR link in the Discord server manually for better tracking.
  • if follow the guidelines and fit to project then label according to pr otherwise close the pr.

Happy Contributing! 🚀

@vercel
Copy link

vercel bot commented Sep 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
vaibhavbabele-github-io Ready Ready Preview Comment Sep 6, 2025 2:46am

@VAIBHAVBABELE
Copy link
Owner

Mistake in fetching data, wrong points and selecting all contributor including me.

@Saminakalwar
Copy link
Author

Mistake in fetching data, wrong points and selecting all contributor including me.

can u give me intended results if u have at one place plz?
willl be easy for me to compare and set probem

@Saminakalwar
Copy link
Author

@github-actions
Copy link

github-actions bot commented Sep 7, 2025

⚠️ Merge Conflict Detected!
Hi @Saminakalwar, your pull request currently has a merge conflict with the base branch. Please resolve the conflict so your PR can be merged.
---
## How to Resolve a Merge Conflict (Step-by-Step)
1. Checkout your PR branch:
bash git checkout fix-issue391

  2. **Fetch the latest changes from the main branch:**
     ```bash
     git fetch origin
     git pull origin main
     ```
  
  3. **Git will show conflict markers in files with conflicts. Open those files, and manually edit them to resolve the differences. Conflict sections look like:**
     ```
     <<<<<<< HEAD
     Your changes
     =======
     Changes from base branch
     >>>>>>> main
     ```
  
  4. **After resolving the conflicts, mark them as resolved:**
     ```bash
     git add <file(s)-you-resolved>
     ```
  
  5. **Commit the resolution:**
     ```bash
     git commit -m "Resolve merge conflict"
     ```
  
  6. **Push your updated branch:**
     ```bash
     git push origin fix-issue391
     ```
  
  ---
  
  🔗 [GitHub Docs: Resolving merge conflicts](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/about-merge-conflicts)
  
  If you need any help, please ask your mentors by replying here!
  
  ---
  
  *This is an automated message to help you resolve merge conflicts and get your PR ready for review. Thank you!*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PR Contributors page fails to render due to broken script paths and undefined variables

2 participants