Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4874 - Update Non-UK VORs and fixes #4876

Merged
merged 23 commits into from
Aug 2, 2023

Conversation

AliceFord
Copy link
Collaborator

@AliceFord AliceFord commented Jul 25, 2023

Fixes #4874

Summary of changes

  • Updated VOR coordinates outside UK
  • Added VOR OSN and AAL, removed VOR VES
  • Remove French fixes below latitude N045
  • Added all Netherlands + Belgium fixes that are enroute / start of a STAR
  • Updated all Ireland fixes that are the start of a STAR
  • Moved fixes outside the UK to their own files and updated compiler config to match

For ease of reviewing the necessary AIP links:
UK MIL Overseas
France
Ireland
Belgium
Germany
Norway
Denmark
Netherlands

Screenshots (if necessary)

French fixes:
Before:
image
After:
image

@AliceFord AliceFord marked this pull request as draft July 25, 2023 09:45
@AliceFord AliceFord self-assigned this Jul 25, 2023
@AliceFord AliceFord added bug Bugs or errors enhancement For new or improved features labels Jul 25, 2023
@AliceFord AliceFord marked this pull request as ready for review July 26, 2023 06:28
@AliceFord AliceFord marked this pull request as draft July 26, 2023 08:29
@AliceFord AliceFord changed the title Fixes #4874 - Update Non-UK VOR Coordinates Fixes #4874 - Update Non-UK VORs and fixes Jul 26, 2023
@AliceFord AliceFord marked this pull request as ready for review July 26, 2023 12:45
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial thoughts, haven't studied all the fix definitions.

compiler.config.json Outdated Show resolved Hide resolved
compiler.config.json Show resolved Hide resolved
Navaids/VOR_Non-UK.txt Outdated Show resolved Hide resolved
Navaids/FIXES_UK.txt Outdated Show resolved Hide resolved
Navaids/FIXES_UK.txt Outdated Show resolved Hide resolved
Navaids/VOR_Non-UK.txt Outdated Show resolved Hide resolved
Navaids/VOR_Non-UK.txt Show resolved Hide resolved
Navaids/VOR_Non-UK.txt Show resolved Hide resolved
Navaids/VOR_Non-UK.txt Show resolved Hide resolved
Navaids/VOR_Non-UK.txt Show resolved Hide resolved
Navaids/FIXES_UK.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So let's uncomment these DME onlys I think, since we have the others, then as far as I'm concerned good to go.

Shame we're increasing overall line count but hopefully will be useful having some of the missing stuff in.

Thanks for doing this @AliceFord

@AliceFord
Copy link
Collaborator Author

So let's uncomment these DME onlys I think, since we have the others, then as far as I'm concerned good to go.

Shame we're increasing overall line count but hopefully will be useful having some of the missing stuff in.

Thanks for doing this @AliceFord

No problemo, much less effort for me + python than any human alone!

@luke11brown luke11brown merged commit 2af35d2 into VATSIM-UK:main Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or errors enhancement For new or improved features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Non-UK VOR Coordinates
4 participants