-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4885 - Create UK AIP Parser Tooling #4886
Conversation
- change api output to be a dictionary, better for expansion later on - change runner to match - change test to match
Hey @AliceFord, as previously mentioned, I've done a bunch of work around this before which is here - eAIP Parser which you're welcome to use / modify / ignore as needed. I've been playing around and think I've found a slightly easier way to get data from the eAIP using pandas dataframes - pd.read_html |
Hi @AliceFord, have/are you likely to be doing more work on this? Just as the PR has been open a while and it's 4 months since it was last editted. I know this kind of thing isn't really a priority, but it would just neaten things up to get it closed as and when it's ready :) Ta. |
Yeah 'tis a good question - I'll give it a look over to make sure it works fine at the mo and then leave it to be pushed - don't think I'll do much more on it for the moment. |
I'll say: it works fine, could be improved with more error checking and other AIP pages, but I don't have the time atm |
That's absolutely fine, can always open another issue/PR to improve upon it once merged at some point if anyone so desires. Thanks very much @AliceFord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't really tested, maybe @chssn could review properly if you have time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging as is. Not fully reviewed but only tooling.
Fixes #4885
Summary of changes
Note: This is a WIP for now.
Screenshots (if necessary)
n/a