-
Notifications
You must be signed in to change notification settings - Fork 63
feat: Waiting list removal reason tracking #4096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The test was not successfully removing anyone from the waiting list as it opened the removal modal but did not actually submit it. + removed_by / deleted_by mixup
…account note for all waiting list removals.
@WillShaw1100 cleaned this up a lil, let me know what you think |
]); | ||
} | ||
|
||
public function test_account_can_be_removed_with_other_reason() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe check that a note has been written?
They look to be in more sensible places than where I left it, thanks. Thanks again, I'm enjoying learning how this all works, and it looks like I didn't suffer too badly.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work both!
->visible(fn (callable $get) => $get('reason_type') === 'other'), | ||
]) | ||
->action(function (WaitingListAccount $record, array $data, $livewire) { | ||
$removal_type = $data['reason_type']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally use camelCase for $theseVariables
, not a big deal but would be good to have consistency
Continued from #4094