Skip to content

feat: Waiting list removal reason tracking #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 30, 2025

Conversation

maxbrokman
Copy link
Contributor

Continued from #4094

@maxbrokman
Copy link
Contributor Author

@WillShaw1100 cleaned this up a lil, let me know what you think

]);
}

public function test_account_can_be_removed_with_other_reason()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe check that a note has been written?

@WillShaw1100
Copy link
Contributor

@WillShaw1100 cleaned this up a lil, let me know what you think

They look to be in more sensible places than where I left it, thanks.
Also thanks for fixing the tests, I had an issue on my local machine which was throwing erroneous issues (now fixed), hopefully they should be in better form next time.

Thanks again, I'm enjoying learning how this all works, and it looks like I didn't suffer too badly.... ☺️

Copy link
Contributor

@CalumTowers CalumTowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work both!

->visible(fn (callable $get) => $get('reason_type') === 'other'),
])
->action(function (WaitingListAccount $record, array $data, $livewire) {
$removal_type = $data['reason_type'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally use camelCase for $theseVariables, not a big deal but would be good to have consistency

@maxbrokman maxbrokman merged commit 683b065 into main May 30, 2025
6 checks passed
@maxbrokman maxbrokman deleted the max-waiting-list-removal-model-fixes branch May 30, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants