prevent overwriting jobs from other instances

VEuPathDB · Nov 9, 2022 · 4006345 · 4006345
1 parent c67cbb7
commit 4006345
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -8,7 +8,7 @@ plugins {
 }
 
 group = "org.veupathdb.lib"
-version = "1.3.4"
+version = "1.3.5"
 
 repositories {
   mavenLocal()

diff --git a/src/main/kotlin/org/veupathdb/lib/compute/platform/AsyncPlatform.kt b/src/main/kotlin/org/veupathdb/lib/compute/platform/AsyncPlatform.kt
@@ -110,6 +110,9 @@ object AsyncPlatform {
    *
    * @throws IllegalArgumentException If the given [queue] value is not a valid
    * queue ID/name.
+   *
+   * @throws IllegalStateException If the ID of the given job already exists and
+   * belongs to another instance of this service.
    */
   @JvmStatic
   fun submitJob(queue: String, job: JobSubmission) {
@@ -119,6 +122,16 @@ object AsyncPlatform {
     if (queue !in JobQueues)
       throw IllegalArgumentException("Attempted to submit a job to nonexistent queue '$queue'.")
 
+    // Lookup the job to see if it already exists.
+    getJob(job.jobID)
+      // If it does exist
+      ?.also {
+        // And it is not owned by this service instance
+        if (!it.owned)
+          // Throw an exception
+          throw IllegalStateException("Attempted to submit a job that would overwrite an existing job owned by another campus (${job.jobID})")
+      }
+
     // Record the new job in the database
     QueueDB.submitJob(queue, job.jobID, job.config?.toString(), job.inputs.keys)