chore: ignore specific lines and bump up coverage (#78)

VGVentures · Mar 15, 2024 · bcfe5b3 · bcfe5b3
1 parent 9b41228
commit bcfe5b3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -20,7 +20,6 @@ jobs:
     uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_package.yml@v1
     with:
       flutter_channel: stable
-      min_coverage: 97
 
   spell-check:
     uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/spell_check.yml@v1

diff --git a/lib/crossword/game/components/section_component.dart b/lib/crossword/game/components/section_component.dart
@@ -28,17 +28,17 @@ class SectionTapController extends PositionComponent
           );
 
       for (final word in [...boardSection.words, ...boardSection.borderWords]) {
-        final wordLength =
-            (word.answer.length * CrosswordGame.cellSize).toDouble();
+        final wordLength = word.answer.length * CrosswordGame.cellSize;
+        final width =
+            word.axis == Axis.horizontal ? wordLength : CrosswordGame.cellSize;
+        final height =
+            word.axis == Axis.vertical ? wordLength : CrosswordGame.cellSize;
+
         final wordRect = Rect.fromLTWH(
           (word.position.x * CrosswordGame.cellSize).toDouble(),
           (word.position.y * CrosswordGame.cellSize).toDouble(),
-          word.axis == Axis.horizontal
-              ? wordLength
-              : CrosswordGame.cellSize.toDouble(),
-          word.axis == Axis.vertical
-              ? wordLength
-              : CrosswordGame.cellSize.toDouble(),
+          width.toDouble(),
+          height.toDouble(),
         );
 
         if (wordRect.contains(localPosition.toOffset())) {
@@ -252,6 +252,8 @@ class SectionComponent extends Component with HasGameRef<CrosswordGame> {
       for (var c = 0; c < wordCharacters.length; c++) {
         late Rect rect;
         if (word.solvedTimestamp != null) {
+          // A bug in coverage is preventing this block from being covered
+          // coverage:ignore-start
           final char = wordCharacters.elementAt(c);
           final charIndex = char.codeUnitAt(0) - 65;
           rect = Rect.fromLTWH(
@@ -260,6 +262,7 @@ class SectionComponent extends Component with HasGameRef<CrosswordGame> {
             CrosswordGame.cellSize.toDouble(),
             CrosswordGame.cellSize.toDouble(),
           );
+          // coverage:ignore-end
         } else {
           rect = Rect.fromLTWH(
             2080,