Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch sections by positions #24

Merged
merged 4 commits into from
Mar 6, 2024
Merged

feat: fetch sections by positions #24

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b39fffc
chore: missing doc
B0berman Mar 5, 2024
7b03a39
feat: remove watch all sections and update watch from position
B0berman Mar 6, 2024
1e68253
chore: update name and description
B0berman Mar 6, 2024
8f0a0cf
test: return null if no section with requested position
B0berman Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions packages/crossword_repository/lib/src/crossword_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,25 +31,21 @@ class CrosswordRepository {
}

/// Watches all the sections of the crossword board
B0berman marked this conversation as resolved.
Show resolved Hide resolved
Stream<List<BoardSection>> watchSections() {
final snapshot = sectionCollection.snapshots();
return snapshot.map(
(snapshot) => snapshot.toBoardSectionList(),
);
}

/// Watches all the sections of the crossword board
Stream<List<BoardSection>> watchSectionsFromPositions(
List<Point<int>> positions,
Stream<BoardSection> watchSectionFromPositions(
B0berman marked this conversation as resolved.
Show resolved Hide resolved
Point<int> position,
) {
final snapshot = sectionCollection
.where(
'position',
whereIn: positions,
'position.x',
isEqualTo: position.x,
)
.where(
'position.y',
isEqualTo: position.y,
)
.snapshots();
return snapshot.map(
(snapshot) => snapshot.toBoardSectionList(),
(snapshot) => snapshot.toBoardSectionList().first,
jsgalarraga marked this conversation as resolved.
Show resolved Hide resolved
);
}
}
13 changes: 2 additions & 11 deletions packages/crossword_repository/test/src/crossword_repository_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,6 @@ void main() {
);
});

group('watchSections', () {
test('returns all the sections', () {
expect(
crosswordRepository.watchSections(),
emits([boardSection1]),
);
});
});

group('watchSection', () {
test('returns the requested section', () async {
expect(
Expand Down Expand Up @@ -85,8 +76,8 @@ void main() {

test('returns the requested sections depending on position', () {
expect(
crosswordRepository.watchSectionsFromPositions([Point(0, 1)]),
emits([section]),
crosswordRepository.watchSectionFromPositions(Point(0, 1)),
emits(section),
);
});
});
Expand Down
Loading