-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update team selection UI #310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwfair
requested review from
jsgalarraga,
B0berman,
AyadLaouissi and
alestiago
as code owners
April 17, 2024 03:05
jsgalarraga
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome Mark!!!
alestiago
reviewed
Apr 17, 2024
alestiago
reviewed
Apr 17, 2024
alestiago
reviewed
Apr 17, 2024
jsgalarraga
previously approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!!
jsgalarraga
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the background and sets the layout for the small and large team selection screens. I am only using the Dash idle animation and the android platform animation. These will be replaced and the hardcoded animation sizes and frame rates will be set once the correct assets have been added.
Loading the assets will get moved to the new loading screen in a future PR.
Screenshots/Video
Screen.Recording.2024-04-16.at.8.52.38.PM.mov
Type of Change
Monday.com Item IDs
6455347350