Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hint feature flag #360

Merged
merged 5 commits into from
Apr 23, 2024
Merged

feat: add hint feature flag #360

merged 5 commits into from
Apr 23, 2024

Conversation

jsgalarraga
Copy link
Member

Description

Added a feature flag in firebase to handle the hints being enabled or disabled

Screenshots/Video

Screen.Recording.2024-04-23.at.11.52.43.mov

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Monday.com Item IDs

6502283104

@jsgalarraga jsgalarraga self-assigned this Apr 23, 2024
alestiago
alestiago approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@alestiago alestiago left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the hint related API endpoints, return a non-2XX status when disabled too?

@jsgalarraga
Copy link
Member Author

Yes, implementing in a follow up

@jsgalarraga jsgalarraga merged commit 6457a0d into main Apr 23, 2024
4 checks passed
@jsgalarraga jsgalarraga deleted the jaime/hint-feature-flag branch April 23, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alestiago alestiago alestiago approved these changes

@B0berman B0berman Awaiting requested review from B0berman B0berman is a code owner

@AyadLaouissi AyadLaouissi Awaiting requested review from AyadLaouissi AyadLaouissi is a code owner

@marwfair marwfair Awaiting requested review from marwfair marwfair is a code owner

Assignees

@jsgalarraga jsgalarraga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsgalarraga @alestiago