Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: numbers casting to be compatible with wasm #395

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix: numbers casting to be compatible with wasm #395

merged 2 commits into from
Apr 25, 2024

Conversation

jsgalarraga
Copy link
Member

Description

Cast all numbers first to num and convert safely to int or double to be compatible with wasm

Screenshots/Video

Not applicable

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jsgalarraga jsgalarraga self-assigned this Apr 25, 2024
@jsgalarraga jsgalarraga merged commit 84df074 into main Apr 25, 2024
10 checks passed
@jsgalarraga jsgalarraga deleted the fix/numbers-casting branch April 25, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alestiago alestiago alestiago approved these changes

@B0berman B0berman B0berman approved these changes

@AyadLaouissi AyadLaouissi Awaiting requested review from AyadLaouissi AyadLaouissi is a code owner

@marwfair marwfair Awaiting requested review from marwfair marwfair is a code owner

Assignees

@jsgalarraga jsgalarraga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsgalarraga @B0berman @alestiago