-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reset game status #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Hugo Walbecq <hugo@verygood.ventures>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a few comments 👍
@marwfair I was planning to a final review, but @AyadLaouissi and I left some comments that might change the code a bit. Before continuing I'll let you resolve the comments first and then I'll resume the review (given that the code might change a bit with the suggested comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, in case we want to move this forward and follow-up the pending comments with additional PRs.
Description
This PR adds a
game_status
document to theboardInfo
collection. Thegame_status
value can either bein_progress
orreset_in_progress
. This value will get set in an upcoming PR by the reset game function.When I started on this task, we were planning on kicking users out of the game and taking them to the welcome screen while the reset was in progress Now, we want to allow all users to be able to join the game, even while the reset is in progress, and players that are already in the game will remain in the game. Players will just see a "reset in progress" modal and they will be unable to solve any words. If the player is in the middle of solving a word when the reset begins, they will be taken out of the solve flow, but their streak will not be broken. While the reset is in progress, the modal's "Keep playing" button will be disabled. After the reset is complete, the reset modal will remain visible and the "Keep playing" button will be enabled.
To test the functionally in dev, update the game status
boardInfo
document and set thevalue
toin_progress
orreset_in_progress
.Screenshots/Video
Screen.Recording.2024-05-02.at.12.57.37.PM.mov
Type of Change
Monday.com Item IDs
6569236519