Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add api client package #5

Merged
merged 4 commits into from
Feb 27, 2024
Merged

feat: add api client package #5

merged 4 commits into from
Feb 27, 2024

Conversation

B0berman
Copy link
Contributor

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Monday item

6105435769

jsgalarraga
jsgalarraga reviewed Feb 26, 2024
View reviewed changes
packages/api_client/lib/api_client.dart Outdated Show resolved Hide resolved
packages/api_client/lib/src/api_client.dart Outdated Show resolved Hide resolved
packages/api_client/lib/src/api_client.dart Outdated Show resolved Hide resolved
packages/api_client/lib/src/api_client.dart Outdated Show resolved Hide resolved
erickzanardo
erickzanardo approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should consider making a brick out of this. This seems super reusable since this is a generic http client that has encryption and firebase app check support.

@jsgalarraga jsgalarraga merged commit 13e8135 into main Feb 27, 2024
4 checks passed
@jsgalarraga jsgalarraga deleted the feat/api-client branch February 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsgalarraga jsgalarraga jsgalarraga approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@B0berman @erickzanardo @jsgalarraga