Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: board not loading when playing through the tutorial #578

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

jsgalarraga
Copy link
Member

Description

Fix board not loading when playing by clicking done after doing the tutorial.
Unified the logic for the large and small layouts and added a missing event regarding player creation

Screenshots/Video

Screen.Recording.2024-06-18.at.11.28.21.mov

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Monday.com Item IDs

6850006421

Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsgalarraga jsgalarraga merged commit 62698d2 into main Jun 18, 2024
3 checks passed
@jsgalarraga jsgalarraga deleted the fix/board-not-loading branch June 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants