Add: miob.conf example for platform based fpgas, Restored #879 #934
Conversation
|
@IgnoreWarnings Is there anything left, which blocks the PR? The CI is passing already.. |
It can be merged. It is confirmed working on hardware. Just the test is ignored, as I elaborated in this conversation (seems to got deleted?). |
IgnoreWarnings
changed the title
IgnoreWarnings
force-pushed
the
miob-config
branch
from
1398c5c to
060732e
Compare
|
I rebased, now the ci fails |
|
Hi @IgnoreWarnings, @n-eiling, I am wondering, do you still forsee progress on this? I am uncertain how Niklas's departure from ACS might have affected this work? Should we keep this PR, or close it? |
TLDR: Hi, this PRs content is complete, but fails the pipeline because ignoring the test doesnt work properly. The config works on hw but due to bad villas code makes the parsing require a vfio hw dependency that doesnt work in ci. I discussed this in more detail in #879 (restored). As you can see in the commits, ignoring the test didnt work somehow. Maybe you can fix this. |
|
I may just have found the error, lets see if ci happy. |
|
@stv0g do you know why the ci pre commit fails with end of file? |
Example can use hw loopback. Signed-off-by: Pascal Bauer <pascal.bauer@rwth-aachen.de> Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Replace 'miob.conf' with 'fpga-miob.conf' in config checks. Signed-off-by: IgnoreWarnings <119685519+IgnoreWarnings@users.noreply.github.com>
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
|
I've rebased it to the latest master for fixing the CI |
Add example config for miob.
Restored: #879