-
Notifications
You must be signed in to change notification settings - Fork 15
Frame hook rework for frame boundary synchronization #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ed2f83a
to
1188993
Compare
This PR also adds a CI job to validate the OpenAPI spec in VILLASnode rather than the documentation repo. The generated OpenAPI documentation can be viewed here: https://acs.pages.rwth-aachen.de/-/public/villas/node/-/jobs/6719350/artifacts/openapi.html#tag/config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good change. Some small notes below.
1188993
to
f0de2fa
Compare
Okay, I spent far to much time on this now :D I did some more refactoring:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small nitpicks for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm getting a bit of a bad feeling that you wrap your custom smart pointer of Sample
with a unique_ptr
, but I guess this makes a future transition away from the manual reference counting easier.
I'm also not too happy with using a But there should be no reason to use a |
f0de2fa
to
ee63d5d
Compare
Done. |
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
ee63d5d
to
2f80f6e
Compare
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
…tions Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
2f80f6e
to
52e4882
Compare
Signed-off-by: Steffen Vogel <steffen.vogel@opal-rt.com>
52e4882
to
4a8dde9
Compare
As discussed with @pjungkamp and @fwege on Tuesday.