Skip to content

Conversation

SystemsPurge
Copy link
Contributor

A collection of fixes and refactoring changes to make frontend run smoother with redux
Includes refactoring into functional components, and adjustment of some breaking changes that happened with the migration

@stv0g
Copy link
Contributor

stv0g commented May 8, 2025

Thats pretty difficult or almost impossible to review for me :(

I just hope it does not break stuff..

I would welcome if we can return to better review practices in the VILLAS repos: Small PRs addressing one issue at a time.

@SystemsPurge
Copy link
Contributor Author

SystemsPurge commented May 8, 2025

@stv0g this is not meant to be the continous practice. It is unorganized due to being a collection of small fixes to exactly avoid a couple breaking changes.
The changes were reviewed when they were initially merged with the fix-requests branch from a fork.
As for the concern about the breaking change, i will shortly give you credentials to a test deployment if you want and you can test it out yourself...
As far as i noticed when i reviewed the PR from the fork to the branch, there were not any.
"Small PRs addressing one issue at a time." is definitely the plan, but keep in mind that there is a couple more things that need to be cleaned up first, and they might be spread across different contexts ( despite having to do with the same issue )

EDIT: if it is ABSOLUTELY an issue, i can squash some

SystemsPurge and others added 10 commits September 29, 2025 09:59
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
add: missing branding

Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
…mponents

Signed-off-by: Andrii Podriez <andrey5577990@gmail.com>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Implement toggle mode
Adjust size of the box for the WidgetPlayer
fix: missing data after merge/rebase

Signed-off-by: Andrii Podriez <andrey5577990@gmail.com>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
@SystemsPurge
Copy link
Contributor Author

@stv0g I squashed commits that have to do with one another.
Some commits contain branding stuff that one can ignore, as they are remnants of merge/rebase conflict resolution attempts and do not affect the actual application.
Also, over the last 4 months, we've had multiple deployments of the whole platform, i've been actively asking about issues and fixing them as they appear, those are the latest squashed commits into update button widget
I hope this now gives the confidence for a positive review

@stv0g
Copy link
Contributor

stv0g commented Sep 30, 2025

Hi @SystemsPurge,

Sorry, I dont have the bandwidth at the moment to review these larger PRs.

@iripiri Do you have some resources to look at this (and the other refactoring/maintenance PRs in VILLASweb)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite some or all of components to account for the flux to redux migration
3 participants