-
Notifications
You must be signed in to change notification settings - Fork 4
Fix requests #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix requests #451
Conversation
Thats pretty difficult or almost impossible to review for me :( I just hope it does not break stuff.. I would welcome if we can return to better review practices in the VILLAS repos: Small PRs addressing one issue at a time. |
@stv0g this is not meant to be the continous practice. It is unorganized due to being a collection of small fixes to exactly avoid a couple breaking changes. EDIT: if it is ABSOLUTELY an issue, i can squash some |
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
add: missing branding Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
…mponents Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
Implement toggle mode Adjust size of the box for the WidgetPlayer fix: missing data after merge/rebase Signed-off-by: Andrii Podriez <andrey5577990@gmail.com> Signed-off-by: SystemsPurge <naktiyoussef@proton.me>
bb0f6e1
to
fb4ea52
Compare
@stv0g I squashed commits that have to do with one another. |
Hi @SystemsPurge, Sorry, I dont have the bandwidth at the moment to review these larger PRs. @iripiri Do you have some resources to look at this (and the other refactoring/maintenance PRs in VILLASweb)? |
A collection of fixes and refactoring changes to make frontend run smoother with redux
Includes refactoring into functional components, and adjustment of some breaking changes that happened with the migration