Skip to content

feat(ModalPage, ModalCard): add outside buttons support #6528

feat(ModalPage, ModalCard): add outside buttons support

feat(ModalPage, ModalCard): add outside buttons support #6528

Triggered via pull request January 30, 2025 09:26
Status Failure
Total duration 6m 11s
Artifacts 16

pull_request_packages.yml

on: pull_request
Detect what files changed
4s
Detect what files changed
Call reusable workflow  /  Run unit tests
1m 57s
Call reusable workflow / Run unit tests
Call reusable workflow  /  get_playwright_docker_image
49s
Call reusable workflow / get_playwright_docker_image
Upload docs dist artifact (styleguide)
2m 5s
Upload docs dist artifact (styleguide)
Upload docs dist artifact (storybook)
1m 23s
Upload docs dist artifact (storybook)
Analyze bundle size
2m 27s
Analyze bundle size
Upload docs dist artifact (beta)
1m 54s
Upload docs dist artifact (beta)
Check dependencies
0s
Check dependencies
Report unit test results
4s
Report unit test results
Matrix: Call reusable workflow / test_e2e
Prepare and upload e2e's HTML report artifact
39s
Prepare and upload e2e's HTML report artifact
Call reusable workflow  /  Download PR workflow payload artifact
0s
Call reusable workflow / Download PR workflow payload artifact
Call reusable workflow  /  Upload PR workflow payload artifact
4s
Call reusable workflow / Upload PR workflow payload artifact
Fit to window
Zoom out
Zoom in

Annotations

2 errors
Call reusable workflow / Run unit tests
Process completed with exit code 1.
ModalOutsideButton > baseline > a11y: has no violations: packages/vkui/src/components/ModalOutsideButton/ModalOutsideButton.test.tsx#L1
Error: expect(received).toHaveNoViolations(expected) Expected the HTML found at $('.vkuiInternalTappable') to have no violations: <div class="vkuiInternalTappable vkuiModalOutsideButton__host vkuiTappable__host vkuiTappable__sizeXNone vkuiTappable__hasPointerNone vkuiClickable__host vkuiClickable__realClickable vkuistyles__-focus-visible vkuiRootComponent__host" role="button" tabindex="0"> Received: "ARIA commands must have an accessible name (aria-command-name)" Fix any of the following: Element does not have text that is visible to screen readers aria-label attribute does not exist or is empty aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty Element has no title attribute You can find more information on this issue here: https://dequeuniversity.com/rules/axe/4.9/aria-command-name?application=axeAPI at Object.toHaveNoViolations (/home/runner/work/VKUI/VKUI/packages/vkui/src/testing/utils.tsx:134:21)

Artifacts

Produced during runtime
Name Size
all-blob-reports-1-10 Expired
150 KB
all-blob-reports-10-10 Expired
141 KB
all-blob-reports-2-10 Expired
145 KB
all-blob-reports-3-10 Expired
141 KB
all-blob-reports-4-10 Expired
142 KB
all-blob-reports-5-10 Expired
147 KB
all-blob-reports-6-10 Expired
138 KB
all-blob-reports-7-10 Expired
140 KB
all-blob-reports-8-10 Expired
136 KB
all-blob-reports-9-10 Expired
137 KB
docs-beta-dist
679 KB
playwright-report
599 KB
pr_workflow_payload
147 Bytes
storybook-dist
6.17 MB
styleguide-dist
2.35 MB
test-output
524 KB