Skip to content

feat(Calendar): add min/max date with time #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 20, 2023
Merged

feat(Calendar): add min/max date with time #5866

merged 5 commits into from
Nov 20, 2023

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Sep 25, 2023 •
edited by Zaycevq
Loading

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью

Описание

Изменения

Добавляем два параметры для minDateTime и maxDateTime, которые позволяют запретить выбор определенных дат с учетом времени

@BlackySoul BlackySoul requested a review from a team as a code owner September 25, 2023 11:03
@BlackySoul BlackySoul linked an issue Sep 25, 2023 that may be closed by this pull request
[Feature]: Мин / макс дата + время для DateInput #5650
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

size-limit report 📦

Path Size
JS 332.39 KB (+0.17% 🔺)
JS (gzip) 101.57 KB (+0.19% 🔺)
JS (brotli) 83.84 KB (+0.2% 🔺)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 255.14 KB (0%)
CSS (gzip) 33.55 KB (0%)
CSS (brotli) 27.21 KB (0%)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 25, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9c1ca1:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

👀 Docs deployed

Commit f9c1ca1

@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (9a98b12) 79.23% compared to head (f9c1ca1) 79.30%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5866      +/-   ##
==========================================
+ Coverage   79.23%   79.30%   +0.07%     
==========================================
  Files         305      305              
  Lines        9598     9623      +25     
  Branches     3247     3261      +14     
==========================================
+ Hits         7605     7632      +27     
+ Misses       1993     1991       -2
Flag Coverage Δ
unittests 79.30% <71.42%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/vkui/src/lib/calendar.ts 79.45% <100.00%> (+4.45%) ⬆️
packages/vkui/src/components/Calendar/Calendar.tsx 79.16% <83.33%> (+6.43%) ⬆️
packages/vkui/src/hooks/useCalendar.ts 77.14% <70.00%> (+10.47%) ⬆️
.../vkui/src/components/CalendarTime/CalendarTime.tsx 46.42% <0.00%> (-12.67%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mendrew
mendrew previously approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@BlackySoul BlackySoul force-pushed the feat/5650/DateInput_add_min_max branch from f7afb3f to 398b3b6 Compare October 3, 2023 05:46
mendrew
mendrew previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 10, 2023
@BlackySoul BlackySoul force-pushed the feat/5650/DateInput_add_min_max branch from 398b3b6 to c7dd0ce Compare October 10, 2023 14:36
mendrew
mendrew previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@github-actions github-actions bot removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 11, 2023
SevereCloud
SevereCloud previously approved these changes Oct 13, 2023
View reviewed changes
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 21, 2023
@BlackySoul BlackySoul removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Oct 23, 2023
@BlackySoul BlackySoul dismissed stale reviews from SevereCloud and mendrew via f9c1ca1 October 30, 2023 08:52
@BlackySoul BlackySoul force-pushed the feat/5650/DateInput_add_min_max branch from c7dd0ce to f9c1ca1 Compare October 30, 2023 08:52
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Oct 30, 2023
@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Nov 6, 2023
@BlackySoul BlackySoul added no-stale Добавляет PR в исключения для автоматического закрытия and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Nov 9, 2023
@BlackySoul BlackySoul merged commit 2190c89 into master Nov 20, 2023
@BlackySoul BlackySoul deleted the feat/5650/DateInput_add_min_max branch November 20, 2023 10:54
vkcom-publisher pushed a commit that referenced this pull request Nov 20, 2023
@BlackySoul @actions-user
feat(Calendar): add min/max date with time (#5866)
635c38a 
* feat(Calendar): add min/max date with time

* feat(Calendar): add  tests for new functionality

* fix(Calendar): add more tests

* Fix minutes default value

* chore: update screenshots
@BlackySoul BlackySoul mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mendrew mendrew mendrew approved these changes

@SevereCloud SevereCloud SevereCloud approved these changes

Assignees
No one assigned
Labels
no-stale Добавляет PR в исключения для автоматического закрытия v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Мин / макс дата + время для DateInput
3 participants
@BlackySoul @mendrew @SevereCloud