Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: rm enums #6043

Merged
merged 1 commit into from
Nov 27, 2023
Merged

BREAKING CHANGE: rm enums #6043

merged 1 commit into from
Nov 27, 2023

Conversation

SevereCloud
Copy link
Contributor

Описание

  • Запретил перечисления
  • Публичные перечисления превратил в объекты

@SevereCloud SevereCloud requested a review from a team as a code owner October 24, 2023 14:04
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

size-limit report 📦

Path Size
JS 342.52 KB (-0.34% 🔽)
JS (gzip) 104.65 KB (-0.46% 🔽)
JS (brotli) 86.53 KB (-0.43% 🔽)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 259.36 KB (0%)
CSS (gzip) 33.9 KB (0%)
CSS (brotli) 27.52 KB (0%)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 24, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e09719:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

e2e tests

Playwright Report

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (d7605d4) 79.58% compared to head (0e09719) 79.35%.

Files Patch % Lines
...ckages/vkui/src/components/ModalRoot/ModalRoot.tsx 46.66% 8 Missing ⚠️
...ages/vkui/src/components/Alert/AlertTypography.tsx 0.00% 3 Missing ⚠️
packages/vkui/src/components/Banner/Banner.tsx 33.33% 2 Missing ⚠️
...components/PanelHeaderButton/PanelHeaderButton.tsx 50.00% 2 Missing ⚠️
packages/vkui/src/components/View/View.tsx 87.50% 2 Missing ⚠️
packages/vkui/src/components/View/ViewInfinite.tsx 84.61% 2 Missing ⚠️
.../vkui/src/components/WriteBarIcon/WriteBarIcon.tsx 71.42% 2 Missing ⚠️
packages/vkui/src/components/Group/Group.tsx 66.66% 1 Missing ⚠️
...kui/src/components/ModalCardBase/ModalCardBase.tsx 66.66% 1 Missing ⚠️
...ponents/ModalCardBase/ModalCardBaseCloseButton.tsx 50.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6043      +/-   ##
==========================================
- Coverage   79.58%   79.35%   -0.24%     
==========================================
  Files         312      312              
  Lines        9960     9833     -127     
  Branches     3330     3306      -24     
==========================================
- Hits         7927     7803     -124     
+ Misses       2033     2030       -3     
Flag Coverage Δ
unittests 79.35% <87.86%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

👀 Docs deployed

Commit 0e09719

inomdzhon
inomdzhon previously approved these changes Oct 25, 2023
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@github-actions github-actions bot added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-actions github-actions bot closed this Nov 9, 2023
@SevereCloud SevereCloud reopened this Nov 17, 2023
@SevereCloud SevereCloud removed the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label Nov 17, 2023
@SevereCloud SevereCloud force-pushed the SevereCloud/issue4239 branch from e136fdd to 513870f Compare November 17, 2023 08:23
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Класс 👍

styleguide/pages/migration_v5.md Outdated Show resolved Hide resolved
mendrew
mendrew previously approved these changes Nov 17, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

inomdzhon
inomdzhon previously approved these changes Nov 20, 2023
@SevereCloud SevereCloud dismissed stale reviews from inomdzhon and mendrew via 0e09719 November 27, 2023 07:46
@SevereCloud SevereCloud force-pushed the SevereCloud/issue4239 branch from 042ed66 to 0e09719 Compare November 27, 2023 07:46
@SevereCloud SevereCloud merged commit 23ce38a into master Nov 27, 2023
23 of 24 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/issue4239 branch November 27, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE][Tech]: Запретить использовать enum
4 participants