Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tabs): add layoutFillMode prop #6114

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Nov 15, 2023


- [ ] Unit-тесты

  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи

Описание

Был запрос на возможность растягивать или сжимать табы вне зависимости от контекста (платформы или использования внутри HorizontalScroll)

Изменения

Добавлен проп layoutFillMode, который позволяет форсить растягивание/сжатие вкладок, сохраняя существующее поведение

P.S.: принимаю пожертвования в виде более подходящего названия для пропа 🥺 @inomdzhon THX!

@BlackySoul BlackySoul requested a review from a team as a code owner November 15, 2023 16:31
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Nov 15, 2023
Copy link
Contributor

github-actions bot commented Nov 15, 2023

size-limit report 📦

Path Size
JS 344.87 KB (+0.06% 🔺)
JS (gzip) 105.34 KB (+0.07% 🔺)
JS (brotli) 87.1 KB (+0.06% 🔺)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 259.36 KB (+0.05% 🔺)
CSS (gzip) 33.9 KB (+0.09% 🔺)
CSS (brotli) 27.52 KB (-0.05% 🔽)

Copy link

codesandbox-ci bot commented Nov 15, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0630438:

Sandbox Source
VKUI TypeScript Configuration
smoosh-violet-yghpyj Issue #6088

Copy link
Contributor

github-actions bot commented Nov 15, 2023

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 15, 2023

👀 Docs deployed

Commit 0630438

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (107c29d) 79.38% compared to head (0630438) 79.63%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6114      +/-   ##
==========================================
+ Coverage   79.38%   79.63%   +0.24%     
==========================================
  Files         306      303       -3     
  Lines        9631     9662      +31     
  Branches     3261     3280      +19     
==========================================
+ Hits         7646     7694      +48     
+ Misses       1985     1968      -17     
Flag Coverage Δ
unittests 79.63% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mendrew
mendrew previously approved these changes Nov 22, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выглядит прекрасно.

В качестве имени пропа можно было бы подумать над stretchMode или extendMode.

@BlackySoul
Copy link
Contributor Author

Выглядит прекрасно.

В качестве имени пропа можно было бы подумать над stretchMode или extendMode.

А ты предлагаешь оставить все значения, как есть, просто переименовать itemsFlexMode в stretchMode/extendMode?

У меня вот есть сомнение по поводу значения stretchMode=shrink 😄

@mendrew
Copy link
Contributor

mendrew commented Nov 22, 2023

А ты предлагаешь оставить все значения, как есть, просто переименовать itemsFlexMode в stretchMode/extendMode?

У меня вот есть сомнение по поводу значения stretchMode=shrink 😄

У меня нет сомнений. По-моему всё предельно близко по значению. Shrink тут как opposite для stretch: https://www.wordhippo.com/what-is/the-opposite-of/stretch.html

@mendrew
Copy link
Contributor

mendrew commented Nov 23, 2023

А ты предлагаешь оставить все значения, как есть, просто переименовать itemsFlexMode в stretchMode/extendMode?
У меня вот есть сомнение по поводу значения stretchMode=shrink 😄

У меня нет сомнений. По-моему всё предельно близко по значению. Shrink тут как opposite для stretch: https://www.wordhippo.com/what-is/the-opposite-of/stretch.html

Ещё на языке вертится expandMode: 'stretch' | 'shrink' | 'auto';

Но я в целом и по поводу itemsFlexMode не против.

inomdzhon
inomdzhon previously approved these changes Nov 23, 2023
@BlackySoul BlackySoul changed the title feat(Tabs): add itemsFlexMode prop feat(Tabs): add layoutFillMode prop Nov 24, 2023
@BlackySoul BlackySoul dismissed stale reviews from inomdzhon and mendrew via 07aca44 November 24, 2023 09:29
inomdzhon
inomdzhon previously approved these changes Nov 24, 2023
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 💖 ✨

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 💖 ✨ #2

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅

@BlackySoul BlackySoul merged commit 6793e79 into master Nov 24, 2023
24 checks passed
@BlackySoul BlackySoul deleted the feat/6088/Tabs_add_items_flex_mode branch November 24, 2023 09:43
vkcom-publisher pushed a commit that referenced this pull request Nov 24, 2023
* feat(Tabs): add itemsFlexMode prop

* feat: Rename prop to gorgeous layoutFillMode

* chore: update screens

* chore: remove useless sreens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5 Автоматизация: PR продублируется в ветку v5
Projects
None yet
3 participants