-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tabs): add layoutFillMode prop #6114
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0630438:
|
e2e tests |
👀 Docs deployed
Commit 0630438 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6114 +/- ##
==========================================
+ Coverage 79.38% 79.63% +0.24%
==========================================
Files 306 303 -3
Lines 9631 9662 +31
Branches 3261 3280 +19
==========================================
+ Hits 7646 7694 +48
+ Misses 1985 1968 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выглядит прекрасно.
В качестве имени пропа можно было бы подумать над stretchMode
или extendMode
.
А ты предлагаешь оставить все значения, как есть, просто переименовать У меня вот есть сомнение по поводу значения |
У меня нет сомнений. По-моему всё предельно близко по значению. Shrink тут как opposite для stretch: https://www.wordhippo.com/what-is/the-opposite-of/stretch.html |
Ещё на языке вертится Но я в целом и по поводу |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 💖 ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ 💖 ✨ #2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
* feat(Tabs): add itemsFlexMode prop * feat: Rename prop to gorgeous layoutFillMode * chore: update screens * chore: remove useless sreens
- [ ] Unit-тестыОписание
Был запрос на возможность растягивать или сжимать табы вне зависимости от контекста (платформы или использования внутри
HorizontalScroll
)Изменения
Добавлен проп
layoutFillMode
, который позволяет форсить растягивание/сжатие вкладок, сохраняя существующее поведениеP.S.: принимаю пожертвования в виде более подходящего названия для пропа 🥺@inomdzhon THX!