fix(TabsItem): use hasReactNode for status #6125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
patch
inomdzhon
removed
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5281e9e:
|
e2e tests |
👀 Docs deployed
Commit 5281e9e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6125 +/- ##
==========================================
+ Coverage 79.38% 79.55% +0.16%
==========================================
Files 306 304 -2
Lines 9631 9605 -26
Branches 3261 3265 +4
==========================================
- Hits 7646 7641 -5
+ Misses 1985 1964 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
previously approved these changes
Nov 20, 2023
github-actions
bot
added
the
patch
Сделано ⚡ 27dee94 |
BlackySoul
previously approved these changes
Nov 20, 2023
inomdzhon
force-pushed
the
imirdzhamolov/issue6119/fix/TabsItem-status-prop-checking
branch
from
27dee94 to
5281e9e
Compare
mendrew
approved these changes
Nov 20, 2023
eugpoloz
approved these changes
Nov 20, 2023
inomdzhon
removed
the
patch
inomdzhon
deleted the
imirdzhamolov/issue6119/fix/TabsItem-status-prop-checking
branch
vkcom-publisher
pushed a commit
that referenced
this pull request
Nov 20, 2023
* fix(TabsItem): use hasReactNode for status
* test(TabsItem): extend e2e config with status={0}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Чтобы учитывать, что
statusможет быть 0, используем функциюhasReactNode.