feat(usePatchChildren): opportunity to provide props #6135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b0915c4:
|
e2e tests |
👀 Docs deployed
Commit b0915c4 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6135 +/- ##
==========================================
+ Coverage 79.35% 79.53% +0.18%
==========================================
Files 312 313 +1
Lines 9833 9867 +34
Branches 3306 3321 +15
==========================================
+ Hits 7803 7848 +45
+ Misses 2030 2019 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mendrew
previously approved these changes
Nov 24, 2023
SevereCloud
previously approved these changes
Nov 27, 2023
BlackySoul
reviewed
Nov 27, 2023
Функция, которая объединяет две схожие функции в одну из двух входных параметров.
- 2-ой аргумент: добавляем возможность прокидывать параметры помимо `ref`/`getRootRef`. - 3-ий аргумент: возможность прокинуть дополнительный обработчик `ref`. В `lib/utils` добавились новые валидаторы `isDOMTypeElement()` и `isValidNotReactFragmentElement()`.
inomdzhon
changed the title
inomdzhon
changed the title
inomdzhon
changed the title
inomdzhon
force-pushed
the
imirdzhamolov/feat/extend-usePatchChildrenRef
branch
from
5730f67 to
b0915c4
Compare
SevereCloud
approved these changes
Nov 27, 2023
BlackySoul
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Добавил два новых аргумента:
ref/getRootRef;ref.Изменения
usePatchChildrenRef()наusePatchChildren()(см. feat(usePatchChildren): opportunity to provide props #6135 (comment))getMergedSameEventsByProps()– функция, которая объединяет две схожие функции в одну из двух входныхпараметров.
lib/utilsдобавились новые валидаторыisDOMTypeElement()иisValidNotReactFragmentElement();